Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting check (Remove Warnings) #99

Closed
Mohitmadhav opened this issue Oct 2, 2021 · 12 comments · Fixed by #148
Closed

Linting check (Remove Warnings) #99

Mohitmadhav opened this issue Oct 2, 2021 · 12 comments · Fixed by #148
Assignees
Labels
Hacktoberfest For Hacktoberfest 2021 medium medium level issue normal-priority Something that has a normal priority refactor Improve code quality

Comments

@Mohitmadhav
Copy link
Member

Description

  • Remove all the warnings as shown in the screenshot below.

Screenshots

image

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. See analysis_options.yaml for all the linting rules
  2. Remove all the unused imports.
  3. Update all the deprecated widgets.
  4. Rectify all other kinds of warnings by following standard practices.

Additional data

I'll check whether the Github actions for linting get passed or not after that.

@Mohitmadhav Mohitmadhav added refactor Improve code quality normal-priority Something that has a normal priority medium medium level issue Hacktoberfest For Hacktoberfest 2021 labels Oct 2, 2021
@Mastersam07
Copy link

Please assign this to me

@Mohitmadhav
Copy link
Member Author

Okay, @Mastersam07.
Please remember to follow all the updated guidelines as specified in the README

@Mohitmadhav
Copy link
Member Author

@Mastersam07 do git pull upstream main to get the updated code.
Then finally you should resolve all the errors and warnings.

@Mohitmadhav
Copy link
Member Author

@Mastersam07 any updates?

@ankitoscar
Copy link
Contributor

@Mastersam07 you have not provided any updates for the last week, hence I am unassigning this issue from you.

@aryang117
Copy link
Contributor

Hey @Mohitmadhav, can I work on this?

@Mohitmadhav
Copy link
Member Author

Sure @aryang117

@Mohitmadhav
Copy link
Member Author

It won't take much time @aryang117. Now there are around 40 warnings only

@aryang117
Copy link
Contributor

@Mohitmadhav Yea, I already fixed a few of them locally.
Once my PR for #147 gets accepted, I'll quickly commit the fixes and make the PR for this

@Mohitmadhav
Copy link
Member Author

Okay @aryang117, you'll have to make it real quick.

@Mohitmadhav
Copy link
Member Author

@aryang117 just remember to do git pull upstream main before making the PR.

@aryang117
Copy link
Contributor

@Mohitmadhav yea I did that and already made a PR with fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest For Hacktoberfest 2021 medium medium level issue normal-priority Something that has a normal priority refactor Improve code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants