Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design changes to the Initial Screen #147

Merged
merged 8 commits into from
Oct 31, 2021
Merged

Design changes to the Initial Screen #147

merged 8 commits into from
Oct 31, 2021

Conversation

aryang117
Copy link
Contributor

Description

Made changes to the Initial Screen.

  • All the buttons are now of same size and consistent (i.e, roundedness of corners for each button has been set to 16). Also tried to introduce visual hierarchy for the buttons, the only exception being SignInWithGoogle button as it uses widgets from a package which are non-modifiable in terms of their appearance(therefore it is white regardless of theme).
  • Tried to make the Initial Screen respond to theme changes made by the user.
    • Light Theme -> Background color is off-white and primary color is deep purple
    • Dark Theme -> Background color is deep purple and primary color is off-white
  • The Auth Field (Email and Password fields) now has borders for dark the light theme to make it easier for the user to identify the fields
  • minor padding/spacing changes to make it overall consistent.

This changes were mostly inspired from what I saw inside the app.

Fixes #138

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Screenshots after design changes-
image
image

Mohitmadhav
Mohitmadhav requested changes Oct 31, 2021
View reviewed changes
Copy link
Member

@Mohitmadhav Mohitmadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @aryang117.
Just see if you can change the color of the Google sign-in button according to both themes.
Its color is not consistent according to both themes. Check if the package allows it.
Rest everything is fine

@aryang117
Copy link
Contributor Author

I don't think that it can be modified,
SocialMediaHandle or the Google Sign-In button has another button inside of it, which is the SignInButton() from the Flutter_sign_in_button package.
The SignInButton() contains different pre-made sign in buttons, but it doesn't allow any modification in terms of their appearance.

In Short, Google Sign-In button has another button inside it (which is from a 3rd Party package) and it's appearance cannot be modified.

I can fix this, but I still have to make one more PR today (other than this one) to complete Hacktoberfest so, I'd prefer do this later. (or if you can make a separate issue for this then I fix right now).

@Mohitmadhav,

@Mohitmadhav
Copy link
Member

Ok then I'll be modified later. No need to make for this right now.

@aryang117 aryang117 mentioned this pull request Oct 31, 2021
Closed
@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 31, 2021
@Mohitmadhav Mohitmadhav merged commit f27bf62 into Project-Easter:main Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohitmadhav Mohitmadhav Mohitmadhav approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial Screen UI change
2 participants
@aryang117 @Mohitmadhav