Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Preference Working Properly #141

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

Samveg12
Copy link
Contributor

@Samveg12 Samveg12 commented Oct 11, 2021

Description

The User Preference textfields dont disappear on clicking on genre preference and gets saved in the database as well

Fixes #130

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checked whether its getting saved in the database

Checklist:

Screen.Recording.2021-10-11.at.3.58.05.PM.mov
  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@Samveg12 Samveg12 changed the title Hacktober/samveg shah User Preference Working Properly Oct 11, 2021
@Samveg12
Copy link
Contributor Author

@Mohitmadhav my code isnt clearing some checks however it works properly when i run it locally. If you could guide me how do I go about to make all checks successful

@Mohitmadhav
Copy link
Member

@Samveg12 that's due to linting issues i.e. the warnings which are there in the program.
After resolving #99, the checks will pass.

Copy link
Member

@Mohitmadhav Mohitmadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FlutterError (This widget has been unmounted, so the State no longer has a context (and should be considered defunct). Consider canceling any active work during "dispose" or using the "mounted" getter to determine if the State is still active.)

To resolve the above error I just wrapped the snack bar with mounted, but now its not sowing the snack bar.

Just look into it

@Mohitmadhav
Copy link
Member

@Samveg12 pull the latest changes by
git pull upstream main

@Mohitmadhav
Copy link
Member

@Samveg12 once tag me when you complete our changes.

@Samveg12
Copy link
Contributor Author

@Mohitmadhav please check i aint getting the error any longer and the snackbar is also getting displayed

Copy link
Member

@Mohitmadhav Mohitmadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samveg12 btw why did you downgrade the dependencies in pubspec.lock?
Also just make these 2 changes:

  • clear the text controller data once the dialog gets saved or cancelled
  • Show a Snackbar displaying User preferences saved when clicked on Save button

Rest everything seems fine

@Samveg12
Copy link
Contributor Author

@Mohitmadhav you dont want the saved data of user which he had entered in the user preference before to be showed by default next time he wants to edit it? Also the snack bar isnt visible ?

@Mohitmadhav
Copy link
Member

No, the snack bar isn't visible bro.
Ok, for now, let it show the saved book and author

@Samveg12
Copy link
Contributor Author

Screen.Recording.2021-10-19.at.10.29.18.AM.mov

@Mohitmadhav please check the snackbar is shown after preference is getting saved and have uploaded the video for the same and pushed the changes also

@Mohitmadhav
Copy link
Member

Ok @Samveg12.
Just pull the latest changes and resolve the conflicts (The app is now migrated to null safety)
Then I'll check it again

@Samveg12
Copy link
Contributor Author

@Mohitmadhav pulled the changes the code is throwing a few errors

@Samveg12
Copy link
Contributor Author

@Mohitmadhav please check

@Samveg12
Copy link
Contributor Author

@Mohitmadhav ?

@Mohitmadhav
Copy link
Member

@Samveg12 check this out:
https://stackoverflow.com/questions/25411366/git-repo-says-its-up-to-date-after-pull-but-files-are-not-updated
Your changes didn't get reflected from the upstream branch

Also do git remote add upstream https://github.com/Project-Easter/Flutter-UI.git

@Mohitmadhav
Copy link
Member

@Samveg12 I'm running the app on my Android device and still, it's not displaying the snack bar..
Just look into this...there are some solutions in StackOverflow but before that
Update your upstream and your branch with null safety.

@Samveg12
Copy link
Contributor Author

@Mohitmadhav does the genre selection work properly in ur system? because since I pulled the changes the ChipsChoice isnt working properly

@Mohitmadhav
Copy link
Member

@Mohitmadhav does the genre selection work properly in ur system? because since I pulled the changes the ChipsChoice isnt working properly

Yes, it's working

@Samveg12
Copy link
Contributor Author

@Mohitmadhav please check now is the snackbar working?

@Mohitmadhav Mohitmadhav merged commit 054b47a into Project-Easter:main Oct 29, 2021
Copy link
Member

@Mohitmadhav Mohitmadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choice chip isn't getting selected nor displaying it's style for which I'll create another issue

@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Preference Form not getting saved
2 participants