-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Preference Working Properly #141
User Preference Working Properly #141
Conversation
@Mohitmadhav my code isnt clearing some checks however it works properly when i run it locally. If you could guide me how do I go about to make all checks successful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FlutterError (This widget has been unmounted, so the State no longer has a context (and should be considered defunct). Consider canceling any active work during "dispose" or using the "mounted" getter to determine if the State is still active.)
To resolve the above error I just wrapped the snack bar with mounted
, but now its not sowing the snack bar.
Just look into it
@Samveg12 pull the latest changes by |
@Samveg12 once tag me when you complete our changes. |
@Mohitmadhav please check i aint getting the error any longer and the snackbar is also getting displayed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Samveg12 btw why did you downgrade the dependencies in pubspec.lock?
Also just make these 2 changes:
- clear the text controller data once the dialog gets saved or cancelled
- Show a Snackbar displaying User preferences saved when clicked on Save button
Rest everything seems fine
@Mohitmadhav you dont want the saved data of user which he had entered in the user preference before to be showed by default next time he wants to edit it? Also the snack bar isnt visible ? |
No, the snack bar isn't visible bro. |
Screen.Recording.2021-10-19.at.10.29.18.AM.mov@Mohitmadhav please check the snackbar is shown after preference is getting saved and have uploaded the video for the same and pushed the changes also |
Ok @Samveg12. |
@Mohitmadhav pulled the changes the code is throwing a few errors |
@Mohitmadhav please check |
@Samveg12 check this out: Also do git remote add upstream https://github.com/Project-Easter/Flutter-UI.git |
@Samveg12 I'm running the app on my Android device and still, it's not displaying the snack bar.. |
@Mohitmadhav does the genre selection work properly in ur system? because since I pulled the changes the ChipsChoice isnt working properly |
Yes, it's working |
633e9cf
to
b3d9e5c
Compare
@Mohitmadhav please check now is the snackbar working? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choice chip isn't getting selected nor displaying it's style for which I'll create another issue
Description
The User Preference textfields dont disappear on clicking on genre preference and gets saved in the database as well
Fixes #130
Type of change
Checklist:
Screen.Recording.2021-10-11.at.3.58.05.PM.mov