Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Saved books (Bookmarks) #118

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Added Saved books (Bookmarks) #118

merged 2 commits into from
Oct 5, 2021

Conversation

Samveg12
Copy link
Contributor

@Samveg12 Samveg12 commented Oct 5, 2021 •
edited by Mohitmadhav
Loading

Description

The books are being added to the save section
Fixes #108

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Screenshot 2021-10-04 at 11 49 35 PM

  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@Mohitmadhav
Copy link
Member

@Samveg12 please tag the issue number too, in the PR.
Fixes # (type your issue number)

@Samveg12
Copy link
Contributor Author

Samveg12 commented Oct 5, 2021

@Mohitmadhav yes done

@Mohitmadhav
Copy link
Member

@Samveg12 why did you downgrade the packages, is it due to the Null safety problem?

@Mohitmadhav Mohitmadhav changed the title changes Added Saved books (Bookmarks) Oct 5, 2021
@Mohitmadhav
Copy link
Member

@Mohitmadhav yes done

I meant in the description, as I did.
But remember this for further issues bro.

@Samveg12
Copy link
Contributor Author

Samveg12 commented Oct 5, 2021

@Mohitmadhav yes was facing issues so downgraded it

@Samveg12
Copy link
Contributor Author

Samveg12 commented Oct 5, 2021

@Mohitmadhav yes done

I meant in the description, as I did. But remember this for further issues bro.

@Mohitmadhav apologies yes will remember it

Mohitmadhav
Mohitmadhav requested changes Oct 5, 2021
View reviewed changes
Copy link
Member

@Mohitmadhav Mohitmadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samveg12 please remember to follow the README guidelines and do
git pull upstream main before pushing any changes.

Some changes from previous PRs aren't reflected in your codebase due to which I'm unable to log in. So do this, and commit again in the same PR.

Rest all your changes are fine.

@Samveg12
Copy link
Contributor Author

Samveg12 commented Oct 5, 2021

@Mohitmadhav yes I did that do I have to make another pull request ?

@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 5, 2021
@Mohitmadhav Mohitmadhav merged commit 54560cc into Project-Easter:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohitmadhav Mohitmadhav Mohitmadhav approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bookmark not working (Provider State Management)
2 participants
@Samveg12 @Mohitmadhav