Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark not working (Provider State Management) #108

Closed
Mohitmadhav opened this issue Oct 3, 2021 · 10 comments · Fixed by #118
Closed

Bookmark not working (Provider State Management) #108

Mohitmadhav opened this issue Oct 3, 2021 · 10 comments · Fixed by #118
Assignees
Labels
bug Something isn't working good first issue good issue for first-time contributors Hacktoberfest For Hacktoberfest 2021 medium medium level issue normal-priority Something that has a normal priority refactor Improve code quality

Comments

@Mohitmadhav
Copy link
Member

Mohitmadhav commented Oct 3, 2021

Description

The Books should get saved in the Saved Books section, once the user bookmarks them but it's not functional right now.

Screenshots

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Check the book provider file: lib\providers\books.dart
  2. Book description file: lib\screens\book_desciption.dart
  3. Other provider files: lib\providers
  4. Try out by adding a Book from Google Books API then saving it as a bookmark for testing.
  5. For that checkout: lib\screens\add_book.dart

Additional data

Add the screenshots of the saved books while making the pull request.

@Mohitmadhav Mohitmadhav added bug Something isn't working refactor Improve code quality normal-priority Something that has a normal priority medium medium level issue Hacktoberfest For Hacktoberfest 2021 good first issue good issue for first-time contributors labels Oct 3, 2021
@Samveg12
Copy link
Contributor

Samveg12 commented Oct 3, 2021

Please assign me this issue

@Mohitmadhav
Copy link
Member Author

Sure @Samveg12 !! Just make sure to follow the README properly.

@Samveg12
Copy link
Contributor

Samveg12 commented Oct 4, 2021

Hi Mohit since I am new to this can u please help me reproduce this issue?

@Samveg12
Copy link
Contributor

Samveg12 commented Oct 4, 2021

Like how do i get this landing page of the screen shot of the book you have put. Every book opens in form of a webview when I click on it

@Samveg12 Samveg12 removed their assignment Oct 4, 2021
@Samveg12
Copy link
Contributor

Samveg12 commented Oct 4, 2021

Also I removed the assignment accidentally please re-assign me this

@Mohitmadhav
Copy link
Member Author

Okay @Samveg12

  • Firstly do git pull upstream main
  • Then go to the Profile page, and add your book.
  • Only books from Google Books API can be added. The booklist is: https://www.googleapis.com/books/v1/volumes?q=isbn
  • After adding your book it will appear on the Library page
  • Then click on it and try to bookmark. It won't work
  • Similarly, you can add many books from the above Google books API link and try to bookmark.

@Samveg12
Copy link
Contributor

Samveg12 commented Oct 4, 2021

Hi @Mohitmadhav I think the add book one function isnt working properly due to which the book isnt being added. Am I making a mistake or is it buggy and you want me to debug that as well?
Screenshot 2021-10-04 at 3 36 34 PM
d

@Mohitmadhav
Copy link
Member Author

It should only add books present in the google books API, but some book images due to which the API is causing a glitch.
But you should surely debug to check.

I removed some of the debug code because the actual code shouldn't contain the debugging.
You can try debugging !!!

@Samveg12
Copy link
Contributor

Samveg12 commented Oct 4, 2021

Hi @Mohitmadhav please check the ss below the book should be in both owned and saved section or only saved section
Screenshot 2021-10-04 at 11 49 35 PM

@Mohitmadhav
Copy link
Member Author

Yes @Samveg12, once you bookmark it should be added to the saved books section.
You must have added it through the Add your book section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue good issue for first-time contributors Hacktoberfest For Hacktoberfest 2021 medium medium level issue normal-priority Something that has a normal priority refactor Improve code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants