Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Profile Page error (sign up bug fix) #119

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Fixed Profile Page error (sign up bug fix) #119

merged 3 commits into from
Oct 5, 2021

Conversation

keyurgit45
Copy link
Contributor

Description

Fixed sign-up bug due to which the profile page was not loading for new users. also added TextField to accept username and phone number in register screen which will send to the database after successful signUp.
Summary of the changes and which issue is fixed.

Fixes #106

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Mohitmadhav
Mohitmadhav requested changes Oct 5, 2021
View reviewed changes
Copy link
Member

@Mohitmadhav Mohitmadhav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crop the image to get it to fit in the circle like it is in the app bar. Rest everything is fine

@Mohitmadhav Mohitmadhav changed the title sign up bug fix Fixed Profile Page error (sign up bug fix ) Oct 5, 2021
@Mohitmadhav Mohitmadhav changed the title Fixed Profile Page error (sign up bug fix ) Fixed Profile Page error (sign up bug fix) Oct 5, 2021
@keyurgit45
Copy link
Contributor Author

Done!

@Mohitmadhav Mohitmadhav merged commit ddf716b into Project-Easter:main Oct 5, 2021
@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohitmadhav Mohitmadhav Mohitmadhav requested changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile Tab not loading
2 participants
@keyurgit45 @Mohitmadhav