Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Tab not loading #106

Closed
Samveg12 opened this issue Oct 3, 2021 · 16 comments · Fixed by #119
Closed

Profile Tab not loading #106

Samveg12 opened this issue Oct 3, 2021 · 16 comments · Fixed by #119
Assignees
Labels
bug Something isn't working easy Easy level issue good first issue good issue for first-time contributors Hacktoberfest For Hacktoberfest 2021 normal-priority Something that has a normal priority

Comments

@Samveg12
Copy link
Contributor

Samveg12 commented Oct 3, 2021

Description

When we click on the profile button in the bottom navigation bar it doesnt loaf

Screenshots

Screenshot 2021-10-03 at 2 57 28 PM

Steps to Reproduce

Click on the profile tab in the bottom navigation bar

  1. Check the provider folder - lib\providers
  2. Profile page: lib\screens\profile\private_profile.dart
  3. Auth files: lib\services\auth.dart

Additional data

None

@Mohitmadhav
Copy link
Member

Description

When we click on the profile button in the bottom navigation bar it doesnt loaf

Screenshots

Upload the current working screenshots here.

Steps to Reproduce

Click on the profile tab in the bottom navigation bar

  1. step 1
Screenshot 2021-10-03 at 2 57 28 PM
  1. step 2
  2. And so on...

Additional data

Anything else you want to add.

It's loading actually if you signed in through google
try out:

  • git pull upstream main
  • flutter clean
  • flutter packages get

This was referenced Oct 3, 2021
@Mohitmadhav Mohitmadhav added bug Something isn't working easy Easy level issue good first issue good issue for first-time contributors Hacktoberfest For Hacktoberfest 2021 normal-priority Something that has a normal priority labels Oct 4, 2021
@Mohitmadhav
Copy link
Member

Mohitmadhav commented Oct 4, 2021

The Email Login is done. @keyurgit45 you can respond here to work on this issue. I'll assign it then.
We can check the Login again after 3 days for checking auto-logout.
Till you resolve this, the forgot password issue will be created.

@keyurgit45
Copy link
Contributor

ok assign me

@keyurgit45
Copy link
Contributor

@Mohitmadhav On the register page, there are only two fields email and password. So on the profile page, It shows "your name" instead of the actual name bcoz we haven't taken it from the user during registration. is it what is supposed to happen? or I'm missing something

@Mohitmadhav
Copy link
Member

Yeah, actually I removed the Username page from the app as the Username was being retrieved from the function below during Google Login...

Screenshot (1524)

But can this be achieved in a similar way for Email Login/Register in Firebase?

@keyurgit45
Copy link
Contributor

keyurgit45 commented Oct 4, 2021

We can take username while registering/sign up and we can overload this method by adding username as an argument and add to the database. what should I do? @Mohitmadhav

@Mohitmadhav
Copy link
Member

Yes, @keyurgit45 that is feasible, you should cover all the entries for Email Login/Register as it is done for Google Login in the above image.

@keyurgit45
Copy link
Contributor

keyurgit45 commented Oct 5, 2021

Yes, @keyurgit45 that is feasible, you should cover all the entries for Email Login/Register as it is done for Google Login in the above image.

OK so I will add a field for name and phone number while register/sign up. and what about emailvarified and photo URL ? Photo can be updated later in profile page I guess

@keyurgit45
Copy link
Contributor

keyurgit45 commented Oct 5, 2021

@Mohitmadhav can you please check if fields are added to the database successfully or not.

@Mohitmadhav
Copy link
Member

Cool @keyurgit45 I think we can call the same function for Email Login/Register.
Don't do anything for the photo URL, it will be set by default.

@Mohitmadhav
Copy link
Member


@Mohitmadhav can you please check if fields are added to the database successfully or not.

Good @keyurgit45, you called the same function, right?(Which I mentioned in the screenshot)

@keyurgit45
Copy link
Contributor

image

yeah. actually did some small changes

@Mohitmadhav
Copy link
Member


@Mohitmadhav can you please check if fields are added to the database successfully or not.

Yes they are added in the Auth and Cloud Firestore user collection

@keyurgit45
Copy link
Contributor

should I make it final?

@Mohitmadhav
Copy link
Member

image

yeah. actually did some small changes

Ok cool @keyurgit45

@Mohitmadhav
Copy link
Member

Yes, now you can create the PR, and I'll review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy Easy level issue good first issue good issue for first-time contributors Hacktoberfest For Hacktoberfest 2021 normal-priority Something that has a normal priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants