Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add LogIn and Logout #115

Merged
merged 2 commits into from
Oct 4, 2021
Merged

add LogIn and Logout #115

merged 2 commits into from
Oct 4, 2021

Conversation

keyurgit45
Copy link
Contributor

Description

This PR will add the login and logout feature. also after 2 days of inactivity, the user will get logged out automatically and the user has to log in again. I have tested the app by taking 2 minutes of time for session expiration.

Summary of the changes and which issue is fixed.

Fixes #101

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the code of conduct of this project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@Mohitmadhav
Copy link
Member

Mohitmadhav commented Oct 4, 2021 •
edited
Loading

@keyurgit45 does it use the Gmail password for logging in?
It's telling wrong password

@keyurgit45
Copy link
Contributor Author

keyurgit45 commented Oct 4, 2021 •
edited
Loading

@keyurgit45 does it use the Gmail password for logging in? It's telling wrong password

It uses the same email and password which the user has given while registering/sign up. please do not register with a new email until we fix #106 coz profile page will not load

@Mohitmadhav
Copy link
Member

image

Don't know why but my name isn't showing here, and I tried all passwords and none is getting accepted.

@Mohitmadhav
Copy link
Member

@keyurgit45 does it use the Gmail password for logging in? It's telling wrong password

It uses the same email and password which the user has given while registering/sign up. please do not register with a new email until we fix #106 coz profile page will not load

For sure I won't.

@Mohitmadhav
Copy link
Member

No need now, I fixed it through the Firebase console...Thanks!!
Also, I recommend you to go for the Forgot your password setup after #106 so the code would remain modular because only 1 person would be looking after the auth part.

Then we can go for Firebase at a later stage if you would be interested.

@keyurgit45
Copy link
Contributor Author

No need now, I fixed it through the Firebase console...Thanks!! Also, I recommend you to go for the Forgot your password setup after #106 so the code would remain modular because only 1 person would be looking after the auth part.

Then we can go for Firebase at a later stage if you would be interested.

Sure, I would like to contribute.

@Mohitmadhav Mohitmadhav added the hacktoberfest-accepted Approval of PR in Hacktober fest label Oct 4, 2021
@Mohitmadhav Mohitmadhav merged commit 75dcd8c into Project-Easter:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohitmadhav Mohitmadhav Mohitmadhav approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Approval of PR in Hacktober fest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email Login and Logout
2 participants
@keyurgit45 @Mohitmadhav