Feature Discussions

[Mohitmadhav]

Hello Contributors 💯

Here we'll be discussing:

• Existing feature implementations (Most important)
• New features (Open for suggestions)
• Feature improvements

Feel free to give inputs on how can we make the app better and improve its scalability 💥

[Mohitmadhav]

#90 (reply in thread)

@keyurgit45 For the Book collection you just need to store the id of the owner of the book. Rest everything will remain the same.

But we cannot be just the uid created in Firebase because the same owner can have multiple books.
Like I have 2 books - Harry Potter and The Alchemist, now both of them cannot have the same id.

So we need to look into it. @ankitoscar what other way can be proposed?

[Mohitmadhav]

#90 (reply in thread)

@keyurgit45 For the Book collection you just need to store the id of the owner of the book. Rest everything will remain the same.

But we cannot be just the uid created in Firebase because the same owner can have multiple books. Like I have 2 books - Harry Potter and The Alchemist, now both of them cannot have the same id.

So we need to look into it. @ankitoscar what other way can be proposed?

@keyurgit45 that unique id for the book will be the doc id of Firebase for every book added by the owner. Now sounds cool i guess

[keyurgit45]

#90 (reply in thread)
@keyurgit45 For the Book collection you just need to store the id of the owner of the book. Rest everything will remain the same.
But we cannot be just the uid created in Firebase because the same owner can have multiple books. Like I have 2 books - Harry Potter and The Alchemist, now both of them cannot have the same id.
So we need to look into it. @ankitoscar what other way can be proposed?

@keyurgit45 that unique id for the book will be the doc id of Firebase for every book added by the owner. Now sounds cool i guess

Yeah..can you send the screenshot cloud firestore once? Frankly speaking, if you database services.dart there are methods already written and I am getting confused

[Mohitmadhav]

[Mohitmadhav]

Yes, the methods are already created, you just need to add the missing fields

[HARSHBHUDOLIA]

Or whenever any user is inputting a book, you can store it in books collection, every book will have a field owner, which will store the userid of the user inputting the book

[HARSHBHUDOLIA]

As you know firebase has a collection document collection document model.

So every user(collection) document can have a collection Books which consists of all the books we have.

We can in addition to that also make a separate collection to store all the books.

This way fetching can be easier.

Inputting the data in two places.

I hope you understood

[keyurgit45]

As you know firebase has a collection document collection document model.

So every user(collection) document can have a collection Books which consists of all the books we have.

We can in addition to that also make a separate collection to store all the books.

This way fetching can be easier.

Inputting the data in two places.

I hope you understood

That is a good idea. To make collection for users we are taking document id from firebaseauth.instance.currentuset.uid

[Mohitmadhav]

so what we can do when the user will register in the app firebase will generate an auto doc id, we need to save it on a local device to access later. so when the user will add a book using that user id stored on the local device we can create a collection and then store books data under-owned books with collection id ISBN number of the book into it.is it ok? @Mohitmadhav @HARSHBHUDOLIA

Yep, saving the doc id will work.
Save the doc ID using flutter_secure_storage package not shared preferences.
See :lib\utils\keys_storage.dart

[keyurgit45]

so what we can do when the user will register in the app firebase will generate an auto doc id, we need to save it on a local device to access later. so when the user will add a book using that user id stored on the local device we can create a collection and then store books data under-owned books with collection id ISBN number of the book into it.is it ok? @Mohitmadhav @HARSHBHUDOLIA

Yep, saving the doc id will work.
Save the doc ID using flutter_secure_storage package not shared preferences.
See :lib\utils\keys_storage.dart

Actually now it is sorted we dont need auto generated doc id we have firebase Auth generated user ID which is unique. We can use that for document creation @Mohitmadhav

[HARSHBHUDOLIA]

The collective doesn't need to have any id. Every time one login the id may change so its not constant also

…

On Wed, Oct 6, 2021, 13:11 Keyur Gandhi ***@***.***> wrote: As you know firebase has a collection document collection document model. So every user(collection) document can have a collection Books which consists of all the books we have. We can in addition to that also make a separate collection to store all the books. This way fetching can be easier. Inputting the data in two places. I hope you understood That is a good idea. To make collection for users we are taking collection id from firebaseauth.instance.currentuset.uid — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#121 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIU6QBYV2V6FNE72VC3CJX3UFP4TJANCNFSM5FLI6SVA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[HARSHBHUDOLIA]

Sorry, I was confused, yes you are right. We can go by what you said

…

On Wed, Oct 6, 2021, 14:04 Harsh Bhudolia ***@***.***> wrote: The collective doesn't need to have any id. Every time one login the id may change so its not constant also On Wed, Oct 6, 2021, 13:11 Keyur Gandhi ***@***.***> wrote: > As you know firebase has a collection document collection document model. > > So every user(collection) document can have a collection Books which > consists of all the books we have. > > We can in addition to that also make a separate collection to store all > the books. > > This way fetching can be easier. > > Inputting the data in two places. > > I hope you understood > > That is a good idea. To make collection for users we are taking > collection id from firebaseauth.instance.currentuset.uid > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#121 (reply in thread)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AIU6QBYV2V6FNE72VC3CJX3UFP4TJANCNFSM5FLI6SVA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > >

[keyurgit45]

yeah, that's what I was asking. Okay👍

[keyurgit45]

As suggested by @HARSHBHUDOLIA we have 2 collections.. each inputted book from the user will go in both collections. is it ok? @Mohitmadhav
note: I tested it on my database.

[Mohitmadhav]

Cool @keyurgit45

[keyurgit45]

video_2021-10-06_23-17-22.mp4

Should I make PR so can review the code? @Mohitmadhav

[Mohitmadhav]

Yes @keyurgit45 make the PR, the rest I'll tell after reviewing the code

[Mohitmadhav]

#129 (comment)

@keyurgit45 I found the cause...Have a look at: https://stackoverflow.com/questions/7908954/google-books-api-searching-by-isbn

And note the difference between:

1. https://www.googleapis.com/books/v1/volumes?q=9788172234980
2. https://www.googleapis.com/books/v1/volumes?q=isbn:9788172234980

We were using the first one, but we need the second one.
Your ISBN query: https://www.googleapis.com/books/v1/volumes?q=isbn:9780062416216

Both of them are - The Alchemist

Now you can resolve this.

[Mohitmadhav]

what is GCP?

Google Cloud Platform

[keyurgit45]

There is one problem. when we use this query we don't get the thumbnail image.
actually there are two books the alchemist one from 2015 and one from 2005 so there are two ISBN numbers. one has thumbnail IMG and one doesn't have.

[keyurgit45]

There is one problem. when we use this query we don't get the thumbnail image.
actually there are two books the alchemist one from 2015 and one from 2005 so there are two ISBN numbers. one has thumbnail IMG and one doesn't have.

Can we show no image found photo if we don't found thumbnail

[Mohitmadhav]

Yes, you did that already I guess, in the makeBookforDB function

[keyurgit45]

Yes, you did that already I guess, in the makeBookforDB function

Yes.. There is some need of modification though.. Will make it and will send PR

[Mohitmadhav]

@keyurgit45 I got an exceptional case:
https://www.googleapis.com/books/v1/volumes?q=isbn:9789388754439

[Mohitmadhav]

So I changed a bit of code in the main. You can pull from there

[keyurgit45]

ohhh a book without an author.. we need to check the null value error for each field then.

[Mohitmadhav]

@keyurgit45 the bookmark is working now, you can pull it from main.
And yes, I'll be creating some issues tonight

[keyurgit45]

@Mohitmadhav Regarding the user_preferences issue, the chips are not clickable. It is happening because of the package, so I tried changing the packages which support null safety but no one worked so can we write our own implementation for that?

[keyurgit45]

@Mohitmadhav who fixed multiple chip choice issue? . I just pulled changes from repo.

[Mohitmadhav]

No, it's not fixed yet. Is it working on your system?

[keyurgit45]

Yup , I guess someone modified the code but one thing not working after saving genres when we open again the dialog it should select all genres which are saved previously. Should I go with this code or I have created my own class and its working fine .what should I do? @Mohitmadhav

[Mohitmadhav]

Yeah, you need to modify that firstly.

[keyurgit45]

I have made changes in the existing code I haven't implemented a new class as the existing code was working with some bugs. please go through. @Mohitmadhav

[Mohitmadhav]

@keyurgit45 lets look at the explore screen and then chat.
Btw I resolved the personalize button error

[keyurgit45]

Yes, I tried a few changes but didn't work. Do you have any idea how to solve this? @Mohitmadhav

[Mohitmadhav]

Hey @keyurgit45, sorry for the late reply. I was busy with college academics and stuff. Can you take up the Firebase Chat issue after which we can release it in the play store? (I'll look into other bugs and features after 15th)

[keyurgit45]

pub get is showing the issue :
This app is using a deprecated version of the Android embedding.
To avoid unexpected runtime failures or future build failures, try to migrate this app to the V2 embedding.
Take a look at the docs for migrating an app: https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects
The plugin cloud_firestore requires your app to be migrated to the Android embedding v2.

[Mohitmadhav]

@keyurgit45 I tried to solve this problem but I am having some issues myself with Gradle. Apart from that, we are in our last month of college. The exam, project reviews, and farewells have kept me busy. But we have decided to make a new UI/UX in the month of May/June/July that will enhance the existing interface. This time I will do it more professionally, so I request you to wait till I am ready to start working on it. If you want to we can discuss the plans with you in detail on a call or a meet link.

[keyurgit45]

Yeah sure. Take your time. In my free time, I will try to look into the error. @Mohitmadhav

[HARSHBHUDOLIA]

@keyurgit45 We plan to have it released in the play store and then work on the revamp version of the app, do you have any friends who can help us with the completion of the app. There are some bugs which we find hard to solve and the deployment part which we have little knowledge about. 80% of the app is done with some expertise rest can be done too. If possible see if you can take help of someone to get the things done.

[keyurgit45]

@keyurgit45 We plan to have it released in the play store and then work on the revamp version of the app, do you have any friends who can help us with the completion of the app. There are some bugs which we find hard to solve and the deployment part which we have little knowledge about. 80% of the app is done with some expertise rest can be done too. If possible see if you can take help of someone to get the things done.

Is there any deadline to upload app to play store? I have told my friends from another college to look into it but not sure if they will help or not.

[HARSHBHUDOLIA]

@keyurgit45 No specific deadline but we plan to launch it in playstore by the month of June, while simulataneously @Mohitmadhav will be working on UI/UX to have a more professional feel to it.