Remove -e from bash args for build plugins to allow bash runs to continue if something fails

[tizzo]

Problem

Lots of users are running phantomjs or selenium on our infrastructure and there's no good way to do that, run your tests, and kill it again.

Solution

Just don't run bash with -e which exits on the first non-zero exit code. This makes us less like jenkins and means the rest of your script will still try to run after you hit the end but

To test

If you create a job with the following without this PR you'll never see the second echo - with it you should see both echos:

steps:
  - name: Testing
    script: |
      true
      echo "That exited $?"
      false
      echo "That exited $?"

[coveralls]

Coverage remained the same at 26.82% when pulling eb23bad on bash-mode-to-allow-continued-run into ec2b61d on master.

[lliss]

Code looks looks good but I cannot reproduce the original issue. In both master and this PR your shell command returns nothing to my probo output.

I tired it with the following step:

- name: Failure
  plugin: Shell
  command: |
    curl nonsense 
    echo "Nar"

And I get unexpected results. On master and on this PR, it passed

I've tried this with a variety of commands and am not able to reproduce the original issue.

[tizzo]

What do you mean? It looks like it succesfully ran curl nonsense which exited non-zero and then printed "Nar".

[lliss]

Right. That was without the patch.