Adding WordPress table prefix configuration. #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lliss
suggested changes
Jul 7, 2017
tortillaj
suggested changes
Nov 13, 2017
| @@ -45,6 +47,7 @@ class WordPressApp extends LAMPApp { | |||
| this.options.wpHome = options.wpHome || options.devHome || null; | |||
| this.options.wpDomain = options.wpDomain || options.devDomain || null; | |||
| this.options.updatePlugins = String(options.updatePlugins).toLowerCase() === 'true'; | |||
| this.options.databasePrefix = options.databasePrefix || "wp_"; | |||
There was a problem hiding this comment.
strings are single quote
This is so that WordPress users can name their tables something other than the default 'wp_'. It is a security best practice to not use the default 'wp_' and we want to encourage that.
076a6b8
to
8b9d4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that WordPress users can name their tables something other than the default 'wp_'. It is a security best practice to not use the default 'wp_' and we want to encourage that.
Please note: this may need to be rebased for the test for the number of lines in a Wordpress script, depending on merge order.