This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
Update for easing function names regexp #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A tiny update that fixes the bug when trying to apply easing function on attribute animation. Current regexp works fine when you use something like "left[outCubic]: 50px" but fails on "@data-num[outCubic]: 100".
| @@ -70,7 +70,7 @@ | |||
| var rxPropValue = /\s*(@?[\w\-\[\]]+)\s*:\s*(.+?)\s*(?:;|$)/gi; | |||
|
|
|||
| //Easing function names follow the property in square brackets. | |||
| var rxPropEasing = /^([a-z\-]+)\[(\w+)\]$/; | |||
| var rxPropEasing = /^([a-z\-@]+)\[(\w+)\]$/; | |||
There was a problem hiding this comment.
Do you think /^@?([a-z\-]+)\[(\w+)\]$/; would be even more concise?
There was a problem hiding this comment.
Nope, this wouldn't work. When you run this regexp on a string like @data-animate[easing]: 100 the result would be:
["@data-animate[easing]", "data-animate", "easing"]
Instead of:
["@data-animate[easing]", "@data-animate", "easing"]
And the @ is required there because you use it then as a name of a property to animate. And you need it to check if it's an attribute or a style.
Although, it could be /^(@?[a-z-]+)[(\w+)]$/. But the result is quite the same.
Prinzhorn
added a commit
that referenced
this pull request
Jun 8, 2014
Update for easing function names regexp
|
Thanks, released as 0.6.26 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny update that fixes the bug when trying to apply easing function on attribute animation. Current regexp works fine when you use something like "left[outCubic]: 50px" but fails on "@data-num[outCubic]: 100".