Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing misc bugs #88

Merged
merged 7 commits into from
Nov 16, 2022
Merged

Fixing misc bugs #88

merged 7 commits into from
Nov 16, 2022

Conversation

zhucaoxiang
Copy link
Collaborator

There are several fixes to the bugs I found when using the code.

@zhucaoxiang
Copy link
Collaborator Author

@thomasgbkruger I added some lines to avoid bugs in some special cases, like

  1. when Npert = 0 (now the default value), sbnormal related variables will not be saved.
  2. when using circular coils, derivatives in nissin will get divided-by-zero errors.

I will merge it for now (some one wants to use it now), but we can create other PRs if necessary.

@zhucaoxiang zhucaoxiang merged commit e3a7e78 into develop Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant