Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splines new #79

Merged
merged 78 commits into from
May 6, 2022
Merged

Splines new #79

merged 78 commits into from
May 6, 2022

Conversation

ni-lon98
Copy link
Collaborator

Addition of spline representation for the coils.
The value of "version" in globals.f90 should be updated to the correct current value.

@zhucaoxiang
Copy link
Collaborator

@ni-lon98 Please let me know when you think I should begin my review and merge.

@zhucaoxiang
Copy link
Collaborator

@ni-lon98 I fixed two small bugs.

bug 1:

forrtl: severe (408): fort: (8): Attempt to fetch from allocatable variable STRAIGHT when it is not allocated

Image              PC                Routine            Line        Source
dfocus             0000000000B5B0BF  Unknown               Unknown  Unknown
dfocus             0000000000A4ECC3  saving_                  5855  saving_m.F90

I found coil%straight is only allocated when coil_type=1, so I also allocate it when coil_type = spline. Also, I remove the lines in saving.f90 which are used to temporarily save coil%straight.

bug2:

forrtl: severe (408): fort: (2): Subscript #2 of the array DERIV has value 10 which is greater than the upper bound of 9

Image              PC                Routine            Line        Source
dfocus             0000000000B5B0BF  Unknown               Unknown  Unknown
dfocus             0000000000A05704  saving_                    69  saving_m.F90

deriv array dimension should be revised since a new column was inserted.

@zhucaoxiang zhucaoxiang merged commit e253249 into develop May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants