Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[-] MO : cronjobs : fix issue with day of week #23

Merged
merged 1 commit into from
Aug 7, 2015
Merged

[-] MO : cronjobs : fix issue with day of week #23

merged 1 commit into from
Aug 7, 2015

Conversation

alexpalyan
Copy link
Contributor

No description provided.

@gaillafr
Copy link
Contributor

gaillafr commented Aug 7, 2015

Hi @freedayko, every countries don't have their first day of week set on "Sunday". So it depends of the timezone associated to the server.
Which issue are you facing?

@alexpalyan
Copy link
Contributor Author

Config form has select box which generated by mktime function
mktime accept day of month, not day of week. so result will depend on last year December that is wrong!
by commit fixed this issue and every value matched his day every time

gaillafr pushed a commit that referenced this pull request Aug 7, 2015
Merge pull request #23 from freedayko/patch-1
641ea68 
[-] MO : cronjobs : fix issue with day of week
@gaillafr gaillafr merged commit 641ea68 into PrestaShopCorp:dev Aug 7, 2015
@gaillafr
Copy link
Contributor

gaillafr commented Aug 7, 2015

Thank you @freedayko, your PR has been merged.
Kind regards.

@alexpalyan alexpalyan deleted the patch-1 branch August 7, 2015 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpalyan @gaillafr