Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rasterRead() no longer returns a function #99

Closed
achubaty opened this issue Oct 3, 2023 · 0 comments
Closed

rasterRead() no longer returns a function #99

achubaty opened this issue Oct 3, 2023 · 0 comments
Assignees

Comments

@achubaty
Copy link
Contributor

achubaty commented Oct 3, 2023

rasterRead() used to return the function corresponding to the string set in reproducible.rasterRead.

this was used in e.g., overlayLCCs():

https://github.com/PredictiveEcology/LandR/blob/development/R/overlayLCCs.R#L70-L71

but this now fails because rasterRead() was modified to evaluate the function, and it now accepts and passes ... to the function, returning a SpatRaster or Raster object.

this change broke overlayLCCs() but at this point, reverting the change will likely break something else.

I will use the original version internally within this function, and note that if similar problems arise elsewhere in the package, that we may need the original version restored for general use in the package.

@achubaty achubaty self-assigned this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant