Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default color for inline prediction to dim #3493

Merged

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Nov 23, 2022

PR Summary

The current default inline prediction color doesn't provide sufficient contrast in terminals that don't use a pure black background (like VSCode terminal). Fix is to use dim white italic escape sequence. Just using dim would result in the color changing depending on the token currently being rendered and for the dark-grey color for parameters it makes it even darker.

Fix #3477

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for submitting the fix!

@daxian-dbw daxian-dbw merged commit 6c7ccc9 into PowerShell:master Nov 23, 2022
@SteveL-MSFT SteveL-MSFT deleted the default-inline-predict-color branch November 23, 2022 23:15
@ghost
Copy link

ghost commented Mar 8, 2023

🎉 v2.3.0-beta0 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predictive IntelliSense's text color is inaccessible
2 participants