Skip to content

Commit

Permalink
update Dockerfile and documentation to work with vite build update
Browse files Browse the repository at this point in the history
  • Loading branch information
SkalskiP committed Oct 26, 2022
1 parent c67713e commit 68c5754
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/issue-greetings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ jobs:
# serve with hot reload at localhost:3000
npm start
```
To ensure proper functionality of the application locally, an npm `6.x.x` and node.js `v12.x.x` versions are required. More information about this problem is available in the [#16](https://github.com/SkalskiP/make-sense/issues/16) issue.
To ensure proper functionality of the application locally, an npm `8.x.x` and node.js `v16.x.x` versions are required. More information about this problem is available in the [#16](https://github.com/SkalskiP/make-sense/issues/16) issue.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,23 +45,23 @@ npm install
# serve with hot reload at localhost:3000
npm start
```
To ensure proper functionality of the application locally, an npm `6.x.x` and node.js `v12.x.x` versions are required. More information about this problem is available in the [#16][4].
To ensure proper functionality of the application locally, npm `8.x.x` and node.js `v16.x.x` versions are required. More information about this problem is available in the [#16][4].

## 🐳 Docker Setup

```bash
# Build Docker Image
docker build -t make_sense docker/
docker build -t make-sense docker/

# Run Docker Image as Service
docker run -dit -p 3000:3000 --restart=always --name=make_sense make_sense
docker run -dit -p 3000:3000 --restart=always --name=make-sense make-sense

# Get Docker Container IP
docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' make_sense
docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' make-sense
# Go to `<DOCKER_CONTAINER_IP>:3000`

# Get Docker Container Logs
docker logs make_sense
docker logs make-sense
```

## ⌨️ Keyboard Shortcuts
Expand Down
4 changes: 2 additions & 2 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM node:14.18.0
FROM node:16.16.0

RUN apt-get update && apt-get -y install git && rm -rf /var/lib/apt/lists/*

RUN mkdir /workspace && \
cd /workspace && \
cd /workspace && \
git clone https://github.com/SkalskiP/make-sense.git && \
cd make-sense && \
npm install
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "make-sense",
"version": "1.0.0",
"version": "1.10.0-alpha",
"private": true,
"dependencies": {
"@emotion/react": "^11.9.3",
Expand Down Expand Up @@ -31,10 +31,10 @@
"yolov5js": "^1.0.0"
},
"scripts": {
"dev": "vite",
"start": "vite",
"dev": "vite --port 3000",
"start": "vite --port 3000",
"build": "vite build",
"preview": "vite preview",
"preview": "vite preview --port 3000",
"test": "jest",
"test:coverage": "jest --coverage",
"lint": "eslint src/**/*.ts src/**.tsx"
Expand Down

0 comments on commit 68c5754

Please sign in to comment.