Follow button #963

apradillap · 2017-09-21T11:37:41Z

Connects to #842

What does this PR do?

follow a subject:
- if you click and you are logged in, you start to follow the subject
- otherwise, the new login modal is opened
already following a subject
- if you click, you stop following a subject

Depending on the context, the button should allow the user to follow:

GobiertoParticipation:
- a process
- an issue
- an event
GobiertoPeople
- a person
- an event

Pending

After talking with Alvaro, the notification page has to be redefined because it will grow a lot depending on the people, events, etc. New Issue

codecov-io · 2017-10-09T08:09:19Z

Codecov Report

Merging #963 into master will increase coverage by 0.08%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
+ Coverage   83.06%   83.14%   +0.08%     
==========================================
  Files         411      411              
  Lines       10033    10053      +20     
==========================================
+ Hits         8334     8359      +25     
+ Misses       1699     1694       -5

Impacted Files	Coverage Δ
...ollers/user/subscription_preferences_controller.rb	`90.9% <ø> (ø)`	⬆️
app/forms/user/subscription_preferences_form.rb	`92.85% <100%> (ø)`	⬆️
app/forms/gobierto_admin/issue_form.rb	`100% <100%> (ø)`	⬆️
app/extensions/gobierto_common/trackable.rb	`100% <100%> (ø)`	⬆️
...ierto_admin/gobierto_participation/process_form.rb	`88.88% <100%> (+0.93%)`	⬆️
app/models/issue.rb	`86.2% <50%> (-2.69%)`	⬇️
app/controllers/user/subscriptions_controller.rb	`90.56% <58.33%> (+16.65%)`	⬆️
app/helpers/gobierto_budgets/application_helper.rb	`75.34% <0%> (-2.74%)`	⬇️
app/models/gobierto_budgets/budget_line_stats.rb	`84.5% <0%> (-1.41%)`	⬇️
app/forms/user/subscription_form.rb	`100% <0%> (+5.71%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee1599...c6a18d7. Read the comment docs.

apradillap · 2017-10-09T15:14:42Z

@Crashillo I have a problem with Follow button, for example in, http:https://participacion.gobify.net/participacion/p/pacto-social-mujer

Can you help me with the magic of CSS? 😄

apradillap · 2017-10-09T15:19:39Z

I'll check what happens in staging by following a process, which shows another alert. For example: http:https://participacion.gobify.net/participacion/p/jjnlvcebnogn-npp0vusbnoirsvon-vlgdlsjbn

furilo · 2017-10-09T16:05:00Z

There you have your CSS. @Crashillo no need to worry.

apradillap · 2017-10-10T10:12:56Z

I have tried the following tests:
GobiertoParticipation:

GobiertoPeople

@furilo, I have a design detail pending. In "Agendas Module" (Ex. http:https://participacion.gobify.net/personas/alcalde-de-madrid) the follow button is not prepared for this module with the styles that it has, I pass you a capture. When you follow a person or an event, you don't see the text.

furilo · 2017-10-10T14:15:55Z

@apradillap the CSS issue is fixed.

Btw, the idea was that this button was Ajax (in the sandbox you even had the interaction), but now the whole page is reloading. Any special reason?

apradillap · 2017-10-10T14:44:35Z

Thanks @furilo for the CSS! I reused another part of the application concerning subscriptions. So I change it to AJAX?

furilo · 2017-10-10T14:50:00Z

yes, it its quick

ferblape · 2017-10-11T06:27:39Z

I think the new styles broke the button About this process:

See in staging: http:https://participacion.gobify.net/participacion/p/presupuestos-participativos-alcobendas

ferblape

I miss tests to follow a Process. Those tests will have shown you the error 500 I caught in the acceptance.

ferblape · 2017-10-11T06:41:32Z

app/controllers/user/subscriptions_controller.rb

@@ -38,15 +38,16 @@ def create
 )
 end

- redirect_to request.referrer
+ redirect_to request.referrer if @user_subscription_form.subscribable.class.name == "Site" ||


This piece of code is not working well when I follow a Process, because is raising a 500 error:

NoMethodError (undefined method `name' for #<GobiertoParticipation::Process:0x007fd7f6ec9ed0>): app/controllers/user/subscriptions_controller.rb:42:in `create'

If you are dealing with HTML and JS requests you should implement a respond_to, and probably redirect to the referer in all HTML requests, and in the JS requests render a create.js.erb partial. In this partial you should render the button in the new state.

So, when a user follows something the button will say "Proceso seguido!"

https://rollbar.com/Populate/gobierto/items/559/

This is the mistake I was telling you yesterday that I had pending, I was aware, I correct it and add the test.

ferblape · 2017-10-11T06:45:19Z

Why I can't see in staging the block Participation in my subscription preferences?

In which branch is it?

apradillap · 2017-10-11T07:59:33Z

Alvaro commented that we have to redefine the page of subscriptions, which made no sense because it was going to grow a lot.

apradillap · 2017-10-11T13:39:16Z

@furilo Except the new styles broke the button About this process that @ferblape comments, I've added tests and I tested:
GobiertoParticipation:

a process
an issue

GobiertoPeople

a person
an event

I have deleted the follow event button within a process.

amiedes · 2017-10-12T21:50:27Z

app/forms/gobierto_admin/gobierto_participation/process_form.rb

@@ -27,6 +28,14 @@ class ProcessForm

 validates :site, :title_translations, :process_type, presence: true
 validates :process_type, inclusion: { in: ::GobiertoParticipation::Process.process_types }
+ validates_presence_of :starts, :ends, if: :process?


I wouldn't add these validations over starts and ends, since they were removed on purpose here to make the process creation flow less restrictive. Applies to both processes and groups.

Please check with @furilo or @ferblape.

Yes, those validations should be removed

ferblape · 2017-10-13T06:15:13Z

app/forms/gobierto_admin/gobierto_participation/process_form.rb

@@ -27,6 +28,14 @@ class ProcessForm

 validates :site, :title_translations, :process_type, presence: true
 validates :process_type, inclusion: { in: ::GobiertoParticipation::Process.process_types }
+ validates_presence_of :starts, :ends, if: :process?


Yes, those validations should be removed

ferblape · 2017-10-13T06:17:20Z

app/views/layouts/application.html.erb

- <a href="#" class="button outline rounded desktop_only follow_process"><i class="fa fa-rss"></i> <span><%= t('.follow_process') %></span></a>
- <% end %>
- <!-- ./ -->
+ <span id="subscribable_button">


apradillap · 2017-10-15T21:11:19Z

Ready to merge

apradillap added 4 commits September 20, 2017 18:26

Add yield follow button to process and issue

bd83ec1

Add yield follow button to event

84ccef8

WIP - Participation alerts

004f8f9

Fix trackable process

800db05

apradillap added gobierto-participation wip labels Sep 21, 2017

apradillap self-assigned this Sep 21, 2017

apradillap added 11 commits September 21, 2017 14:39

Add tracking into issues

d1fe3a3

Check user_signed_in to show follow button

07cb621

Normalize i18n keys

94c8dc2

Merge branch 'master' into 842-follow-button

e7e65a1

Add process and issue in user subscriptions

e0ee000

Change subscridable with current_process

e3dd97c

Fix subscribe and unsuscribe to process and issues

bbeb9fc

Undo modify subscriptions

b404234

Renamed views and i18n keys

26080d3

Merge branch 'master' into 842-follow-button

386d76f

Complete new follow event and new follow person

2fe2d04

Fix CSS for button

8554386

Adapt test to follow button

db9d9f5

furilo added 2 commits October 10, 2017 15:59

Merge branch 'master' into 842-follow-button

8195588

Fix CSS for follow button

e67f3e4

Add ajax to subscribable button

6e38594

ferblape requested changes Oct 11, 2017

View reviewed changes

apradillap added 2 commits October 11, 2017 14:35

Add tests and change follow button to respond to js

791ff9e

Fix subscription block process event

438ec80

apradillap requested review from ferblape and furilo October 11, 2017 13:39

apradillap removed the wip label Oct 11, 2017

apradillap changed the title ~~WIP - Follow button~~ Follow button Oct 11, 2017

amiedes reviewed Oct 12, 2017

View reviewed changes

ferblape requested changes Oct 13, 2017

View reviewed changes

apradillap added 2 commits October 13, 2017 09:16

Remove processes and groups form validations

1d7a44e

Fix process form test without starts_at and ends_at validations

bd177bb

apradillap requested review from ferblape and amiedes October 13, 2017 12:48

Merge branch 'master' into 842-follow-button

c6a18d7

apradillap merged commit 671bae8 into master Oct 16, 2017

apradillap deleted the 842-follow-button branch October 16, 2017 11:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Follow button #963

Follow button #963

apradillap commented Sep 21, 2017 •

edited

Loading

codecov-io commented Oct 9, 2017 •

edited

Loading

apradillap commented Oct 9, 2017

apradillap commented Oct 9, 2017

furilo commented Oct 9, 2017

apradillap commented Oct 10, 2017

furilo commented Oct 10, 2017

apradillap commented Oct 10, 2017 •

edited

Loading

furilo commented Oct 10, 2017

ferblape commented Oct 11, 2017

ferblape left a comment

ferblape Oct 11, 2017

ferblape Oct 11, 2017

apradillap Oct 11, 2017

ferblape commented Oct 11, 2017

apradillap commented Oct 11, 2017

apradillap commented Oct 11, 2017

amiedes Oct 12, 2017

ferblape Oct 13, 2017

ferblape Oct 13, 2017

ferblape Oct 13, 2017

apradillap commented Oct 15, 2017

Follow button #963

Follow button #963

Conversation

apradillap commented Sep 21, 2017 • edited Loading

What does this PR do?

Pending

codecov-io commented Oct 9, 2017 • edited Loading

Codecov Report

apradillap commented Oct 9, 2017

apradillap commented Oct 9, 2017

furilo commented Oct 9, 2017

apradillap commented Oct 10, 2017

furilo commented Oct 10, 2017

apradillap commented Oct 10, 2017 • edited Loading

furilo commented Oct 10, 2017

ferblape commented Oct 11, 2017

ferblape left a comment

Choose a reason for hiding this comment

ferblape Oct 11, 2017

Choose a reason for hiding this comment

ferblape Oct 11, 2017

Choose a reason for hiding this comment

apradillap Oct 11, 2017

Choose a reason for hiding this comment

ferblape commented Oct 11, 2017

apradillap commented Oct 11, 2017

apradillap commented Oct 11, 2017

amiedes Oct 12, 2017

Choose a reason for hiding this comment

ferblape Oct 13, 2017

Choose a reason for hiding this comment

ferblape Oct 13, 2017

Choose a reason for hiding this comment

ferblape Oct 13, 2017

Choose a reason for hiding this comment

apradillap commented Oct 15, 2017

apradillap commented Sep 21, 2017 •

edited

Loading

codecov-io commented Oct 9, 2017 •

edited

Loading

apradillap commented Oct 10, 2017 •

edited

Loading