Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All IBM Notes imported events are public by default #646

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

ferblape
Copy link
Member

Unexpected

What does this PR do?

We were wrong assuming the 'transparency' field was the privacy field of a IBM Notes Event. By default IBM notes doesn't publish any private event, so we don't need to check any field.

@ferblape ferblape requested a review from amiedes April 20, 2017 08:33
@ferblape ferblape force-pushed the ibm-notes-dont-filter-events branch from 472231c to 819edf5 Compare April 20, 2017 08:35
@codecov-io
Copy link

codecov-io commented Apr 20, 2017

Codecov Report

Merging #646 into stable will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable     #646      +/-   ##
==========================================
+ Coverage   67.56%   67.61%   +0.05%     
==========================================
  Files         298      298              
  Lines        7312     7312              
==========================================
+ Hits         4940     4944       +4     
+ Misses       2372     2368       -4
Impacted Files Coverage Δ
lib/ibm_notes/person_event.rb 100% <100%> (ø) ⬆️
app/models/gobierto_budgets/site_stats.rb 79.16% <0%> (+1.38%) ⬆️
app/models/gobierto_budgets/budget_line_stats.rb 87.32% <0%> (+1.4%) ⬆️
app/pub_sub/publisher.rb 80% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd9f97...819edf5. Read the comment docs.

@ferblape ferblape force-pushed the ibm-notes-dont-filter-events branch from d61f952 to 819edf5 Compare April 20, 2017 10:19
@ferblape ferblape merged commit e956503 into stable Apr 20, 2017
@ferblape ferblape deleted the ibm-notes-dont-filter-events branch April 20, 2017 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants