Require no authentication in determined User session related actions #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are: In Admin namespace - Sign in - Confirmation - Invitation acceptance - Password change request - Password change In User namespace: - Registration - Sign in - Confirmation - Invitation acceptance - Password change request - Password change
ferblape
reviewed
Nov 19, 2016
| @@ -10,6 +10,7 @@ | |||
| # Admin module | |||
| namespace :admin do | |||
| get '/' => 'welcome#index', as: :root | |||
| get '/login' => 'sessions#new' | |||
There was a problem hiding this comment.
👀 not a big deal, but you are duplicating here sessions#new
There was a problem hiding this comment.
Yep, that was just for consistency. This way we're providing more semantic URLs in both user and admin namespaces:
- /user/login
- /user/signup
- /admin/login
Thanks for pointing that out 👌
ferblape
deleted the
59-require-no-authentication-on-user-session-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #59.
What does this PR do?
As the title says, we're requiring no authentication on every User and Admin session related actions. Those are:
In Admin namespace
In User namespace
It also increases the test coverage and normalizes implementations across namespaces.
How should this be manually tested?
Just check every single action from the list above halts the workflow by showing the "You are already signed in" message.