Run linter autofixable issues #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Crashillo could you check the conflicts? |
|
Solved |
|
Hmmmm, there's a broken spec which is not broken in master, makes me suspect. Could you take a look? Ping me if you need help |
|
Yep, I noticed before, I thought it would be related to the |
Crashillo
force-pushed
the
full-linting-code
branch
from
a8fcbab
to
6aa86bb
Compare
Crashillo
force-pushed
the
full-linting-code
branch
from
6aa86bb
to
9daa43c
Compare
|
I'm not being able to solve these tests: in my local environment they pass, so I presumed they were flaky tests... but any time I run them again in the server, they fail. |
|
Fixed by refreshing CircleCI cache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✌️ What does this PR do?
This PR runs automatic fixes provided by each linting rule:
Such default rules are extended via: