Refactor SiteConfiguration class to handle properties #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danguita
changed the title
danguita
force-pushed
the
site-configuration-object-refactor
branch
from
164b18f
to
fd4637f
Compare
danguita
force-pushed
the
site-configuration-object-refactor
branch
from
fd4637f
to
d39ffd7
Compare
|
Looks fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It slightly updates the
SiteConfigurationclass to take control on passed parameters in terms of data structure. It also introduces a simple API to access these properties in a more conventional way.How should this be manually tested?
It affects almost every part in the application, so let's just check everything regarding site modules and demo mode is working as expected.