Gobierto Visualizations / Costs: refactor and update data #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crashillo
requested changes
Sep 1, 2021
| for (let amounts = 0; amounts < amountStrings.length; amounts++) { | ||
| d[amountStrings[amounts]] = convertStringToNumbers( | ||
| d[amountStrings[amounts]] | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| let yearsCosts = [...new Set(rawData.map(item => item.any_))]; | ||
| function getPopulation(year) { |
There was a problem hiding this comment.
This function is totally worthless:
- There is only one use (L160)
- It's running over and over through the yearsCosts array
- yearsCosts array is defined outside the function
Why not this? The current code is quite hard to understand
const ix = yearsCosts.findIndex(x => x === d["any_"])
d.population = population[ix]
There was a problem hiding this comment.
Much better, done.
|
What's pending to merge this? |
Last Friday, they changed some data, so we are pending their review. |
|
Careful, the test that it's failing is caused by the text you updated, please review https://app.circleci.com/pipelines/github/PopulateTools/gobierto/4546/workflows/4cb58281-9e50-497c-bfe6-c690a0fb848b/jobs/39397 |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/PopulateTools/issues/issues/1335
✌️ What does this PR do?
🔍 How should this be manually tested?
Staging