Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate stylelint #3592

Merged
merged 3 commits into from
Dec 23, 2020
Merged

Migrate stylelint #3592

merged 3 commits into from
Dec 23, 2020

Conversation

Crashillo
Copy link
Member

@Crashillo Crashillo commented Dec 22, 2020

Closes #2563

✌️ What does this PR do?

Removes sass-lint deprecated library, in favour of stylelint

  • HoundCI config updated
  • NPM scripts updated

Considerations

The following rules have been disabled. Perhaps we should satisfy them in a future.

  • at-rule-no-unknown: null
  • no-descending-specificity: null
  • selector-type-no-unknown: null

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #3592 (42d5f98) into master (8104661) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3592   +/-   ##
=======================================
  Coverage   84.35%   84.36%           
=======================================
  Files         791      791           
  Lines       21147    21147           
=======================================
+ Hits        17839    17841    +2     
+ Misses       3308     3306    -2     
Impacted Files Coverage Δ
app/models/gobierto_budgets/data/lines.rb 94.28% <0.00%> (+0.95%) ⬆️
app/helpers/gobierto_budgets/application_helper.rb 64.58% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8104661...42d5f98. Read the comment docs.

Copy link
Contributor

@jorgeatgu jorgeatgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add our own file of stylelint rules, including comments in the rules to give context to the errors.

Example

@Crashillo
Copy link
Member Author

Hahahaha, funny error messages

@ferblape ferblape merged commit 3ba51ce into master Dec 23, 2020
@ferblape ferblape deleted the migrate-stylelint branch December 23, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass-lint is no longer maintained
3 participants