Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GeoJSON world countries #3446

Closed
wants to merge 1 commit into from
Closed

Add GeoJSON world countries #3446

wants to merge 1 commit into from

Conversation

jorgeatgu
Copy link
Contributor

Closes #N

✌️ What does this PR do?

Add a GeoJSON with the countries of the world, format: ISO 3166-1 alpha 2 code.

ferblape
ferblape requested changes Nov 3, 2020
View reviewed changes
Copy link
Member

@ferblape ferblape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of loading it from public, with Webpacker it could be included with a require using a loader, right? This way we could move the file to gencat-engine and avoid an extra request when the page is loaded

Can you confirm if it's possible?

@jorgeatgu
Copy link
Contributor Author

Another way without WebPacker, import geojson as a module.

@ferblape
Copy link
Member

ferblape commented Nov 3, 2020

Ok

@jorgeatgu jorgeatgu closed this Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferblape ferblape ferblape requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgeatgu @ferblape