Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base skeleton for the new Gobierto Dashboards module #3028

Merged
merged 4 commits into from
May 7, 2020

Conversation

eltercero
Copy link
Member

Closes #2995

✌️ What does this PR do?

It adds a new (for now, empty) module called Gobierto Dashboards that can be enabled through the admin panel.

🔍 How should this be manually tested?

As an admin, you should be able to enable/disable the new module in staging from the Customize Site (for instance, in the madrid site: https://madrid.gobify.net/admin/sites/2/edit). Once enabled there shouldn't be any changes in the main navigation section of the site, but these urls should be now accessible:

If disabled, those urls should not be accessible.

For now, the content of each of those pages is a single string with its name.

👀 Screenshots

Before this PR

Captura de pantalla 2020-05-06 a las 9 28 04

After this PR

Captura de pantalla 2020-05-06 a las 9 31 52

:shipit: Does this PR changes any configuration file?

  • new environment variable in .env.example?
  • new entry in config/application.yml?
  • new entry in config/secrets.yml?

(Changes in these files might need to update the role in Ansible)

📖 Does this PR require updating the documentation?

  • new site configuration variable?
  • new site template?
  • new module/submodule settings?
  • significant changes in some feature?

- Entry in application.yml
- Entries in routes.rb
- New module
- Controllers with empty actions
- Empty views
- Empty JS and SCSS files
- Eppty locale files
- Controllers with empty actions
- Empty views
- Empty locale files
@ferblape
Copy link
Member

ferblape commented May 7, 2020

@entantoencuanto I'm going to merge this PR of the new module because there are going to be more branches based on this.

@ferblape ferblape merged commit d91040f into master May 7, 2020
@ferblape ferblape deleted the 2995-dashboards-module-skeleton branch May 7, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Gobierto dashboards module
2 participants