Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify and simplify configuration #277

Merged
merged 6 commits into from
Jan 30, 2017
Merged

Unify and simplify configuration #277

merged 6 commits into from
Jan 30, 2017

Conversation

ferblape
Copy link
Member

@ferblape ferblape commented Jan 26, 2017

Connects to #272

What does this PR do?

  • returns secrets.yml to the repository. We don't need an example any more
  • simplifies a bit the env file by removing emails configurations
  • removes some default variables from the application.yml
  • given that we use a different application.yml per installation, use the repository application.yml to dev and test environments only
  • updates the PR template

And extra ball: removes deploy configuration.

How should this be manually tested?

Check staging works as usual & check emails address.

@ferblape ferblape merged commit 68dffaf into stable Jan 30, 2017
@ferblape ferblape deleted the 272-unify-configuration branch January 30, 2017 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant