Admin's Site management refactor #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow managing modules per site. - Retrieve modules available per installation. - Add Site#title attribute. - Add Site.sorted scope.
|
A new iteration is about to come. The build is bright green so I'm moving this forward 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #17.
What does this PR do?
It completes a new iteration on the Admin's Site management section by setting some more foundations, allowing module management and improving the abstraction layer between the Site form and the actual Repository.
It also implements the behavior behind Admin's authorization levels by allowing
managerlabeled one to access every Site available out there. On the other hand,regularAdmins are only allowed to manage their own Sites.How should this be manually tested?
Check out the Sites management section in Admin's namespace at https://gobierto.dev/admin/sites/, and perform any kind of operation to check how data is transformed and stored.