Gobierto Indicators module #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sections skeleton Minimal header and intro Better header structure Better intro Add basic widget structure and style Improve header classes Push all the sections Refactor nav a bit, prepare for fixed position Upload png CSS refactor Move the utils Fix active section decoration Responsive navbar Add links to share buttons, improve decoration Widget info hover styles Sandbox menu items New design for the indicators page, start working on the graphics Chart structure Age distribution chart draft Add chart headline, various fixes Improve axis handling Fix merge Read TBI API token from the sandbox Fix age distribution responsive handler WIP unemployment calculation WIP cards data retrieval implementation Implement cards percentage variations Isolate card indicators painting code Populate the indicator cards and handle different data types Indicators refactor. Flexible card data retrieval for and metadata WIP Paint all the indicators Fix the indicators Fix rendering and age distribution vis x axis adjustment Data driven titles, calculate city average age Show dataset info on cards Improve indicator cards interaction, add all the info Prepare unemployment by age pct values Another way to calculate the pct Add lodash Add scatterplot WIP Fix responsive handler Calculate ratio Add Spanish locale Reference D3 Spanish locale on application.js Fix age distribution locale Remove Spanish locale, as its global now Scatterplot: Add custom formatter Scatterplot text label of current city SVG annotation Switch to a Plasma color scale & fix the encoding Implement voronoi and tooltip WIP Unemployment line chart WIP Add top margin Fix extent and pct calculation for the last year Change y axis alignment Make the line chart responsive Unemployment by sectors chart Implement voronoi tooltip Add distance limited voronoi tooltip Age distribution styles Improve responsive handler Fix responsive handler Fix scatterplot styles Remove legacy annotation function and label Improve custom formatter
ferblape
force-pushed
the
65-indicators-sandbox-squashed
branch
from
d59d5bf
to
1c33bb7
Compare
ferblape
force-pushed
the
65-indicators-sandbox-squashed
branch
from
d48f940
to
1cfbcd8
Compare
Current coverage is 90.81% (diff: 100%)@@ stable #248 diff @@
==========================================
Files 181 181
Lines 3976 3976
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 3612 3611 -1
- Misses 364 365 +1
Partials 0 0
|
|
I have just released this branch to staging. We can see real indicators for Madrid in http:https://madrid.gobify.net/indicadores Next steps: @furilo and @ferblape to review and create issues if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the sandbox of #65
@martgnz says this is OK for merging as a v1.
Works
To be done
Needs review
cc @ferblape @furilo.