Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2382 - API changes for project page front #2393

Merged
merged 18 commits into from
Jul 1, 2019
Merged

Conversation

amiedes
Copy link
Contributor

@amiedes amiedes commented Jun 27, 2019

(!) To be merged after #2383

Closes #2382

✌️ What does this PR do?

Implements a mechanism so the different plugins can attach custom information to any Gobierto Model. Specifically for this case, modifies the JSON returned by the GobiertoPlans project API so it includes information about budget, human resources and indicators.

🔍 How should this be manually tested?

You can edit this project in staging and see the API response in http:https://talavan.gobify.net/planes/gobierto_plans/api/plan_projects/17/2198

:shipit: Does this PR changes any configuration file?

No

📖 Does this PR require updating the documentation?

@codecov-io
Copy link

codecov-io commented Jun 27, 2019

Codecov Report

Merging #2393 into master will increase coverage by 0.09%.
The diff coverage is 75.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2393      +/-   ##
==========================================
+ Coverage   81.25%   81.35%   +0.09%     
==========================================
  Files         687      693       +6     
  Lines       17942    18094     +152     
==========================================
+ Hits        14579    14720     +141     
- Misses       3363     3374      +11
Impacted Files Coverage Δ
lib/budgets_seeder.rb 0% <0%> (ø)
...corators/gobierto_plans/category_term_decorator.rb 98.38% <100%> (+0.08%) ⬆️
...lans/category_term_decorator_budgets_attachment.rb 100% <100%> (ø)
...s/gobierto_common/custom_field_functions/budget.rb 96.55% <100%> (ø)
...egory_term_decorator_human_resources_attachment.rb 100% <100%> (ø)
...ugin/lib/custom_fields_data_grid_plugin/railtie.rb 100% <100%> (ø) ⬆️
app/models/gobierto_plans/node.rb 87.5% <100%> (+0.65%) ⬆️
...s/category_term_decorator_indicators_attachment.rb 100% <100%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84737e8...de59150. Read the comment docs.

lib/budgets_seeder.rb Show resolved Hide resolved
lib/budgets_seeder.rb Show resolved Hide resolved
@amiedes amiedes marked this pull request as ready for review June 28, 2019 09:40
@amiedes
Copy link
Contributor Author

amiedes commented Jun 28, 2019

This is ready. @ferblape I'll update this PR and ping you for a review once #2383 is merged.

@amiedes amiedes requested a review from ferblape June 28, 2019 15:17
@ferblape ferblape merged commit 6deb194 into master Jul 1, 2019
@ferblape ferblape deleted the 2382-project-page-front branch July 1, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan plugin: extract values in the project page
4 participants