Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2323 vocabulary tags custom field #2354

Merged
merged 7 commits into from
Jun 18, 2019
Merged

Conversation

entantoencuanto
Copy link
Member

@entantoencuanto entantoencuanto commented Jun 4, 2019

Closes #2323

✌️ What does this PR do?

  • Adds a tags custom field type which allow the creation of terms of tags vocabulary on creation

Pending

I'll try to change the behaviour with the createTag callback of select2.

🔍 How should this be manually tested?

👀 Screenshots

Before this PR

🚫

After this PR

2323-after

:shipit: Does this PR changes any configuration file?

No

(Changes in these files might need to update the role in Ansible)

📖 Does this PR require updating the documentation?

No

}

function _hasAccent(term) {
console.log(term.match(/[`´^¨][aeiouAEIOU]/))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected console statement no-console

@entantoencuanto entantoencuanto force-pushed the 2323-vocabulary_tags_custom_field branch from 77558ab to b51c710 Compare June 5, 2019 15:08
@entantoencuanto entantoencuanto marked this pull request as ready for review June 5, 2019 15:25
@codecov-io
Copy link

codecov-io commented Jun 6, 2019

Codecov Report

Merging #2354 into master will decrease coverage by 0.02%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2354      +/-   ##
==========================================
- Coverage   81.32%   81.29%   -0.03%     
==========================================
  Files         678      678              
  Lines       17788    17796       +8     
==========================================
+ Hits        14466    14468       +2     
- Misses       3322     3328       +6
Impacted Files Coverage Δ
...s/gobierto_common/custom_field_record_decorator.rb 75.75% <0%> (ø) ⬆️
...to_common/custom_field_value/vocabulary_options.rb 29.41% <0%> (-20.59%) ⬇️
app/models/gobierto_common/custom_field.rb 94.23% <100%> (+0.11%) ⬆️
...obierto_admin/gobierto_common/custom_field_form.rb 92.47% <100%> (ø) ⬆️
app/helpers/gobierto_budgets/application_helper.rb 61.45% <0%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b670b4a...481df9f. Read the comment docs.

@ferblape
Copy link
Member

ferblape commented Jun 6, 2019

Tags with accents don't work very well, I haven't been able to create tags with accents even with your solution. I have been investigating but we need to go deeper.

@ferblape ferblape merged commit bb133c2 into master Jun 18, 2019
@ferblape ferblape deleted the 2323-vocabulary_tags_custom_field branch June 18, 2019 12:30
@ferblape
Copy link
Member

Tags with accents don't work very well, I haven't been able to create tags with accents even with your solution. I have been investigating but we need to go deeper.

But I'm mergin this to avoid branch conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Field: Vocabulary - Tags
4 participants