Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Site's logo management via AWS S3 adapter #169

Merged
merged 7 commits into from
Dec 16, 2016
Merged

Implement Site's logo management via AWS S3 adapter #169

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b4cdccb
Add `aws-sdk` gem, not auto required
danguita Dec 16, 2016
9ef1397
Add AWS related ENV vars to example file
danguita Dec 16, 2016
42c2489
Remove placeholders in empty ENV variables, for consistency
danguita Dec 16, 2016
b2be38d
Implement `FileUploader::S3` library to abstract these operations
danguita Dec 16, 2016
e199925
Integrate `FileUploader::S3` handle the Site logo attachment
danguita Dec 16, 2016
7b729da
Localise attributes via `SiteForm` instead of the model itself
danguita Dec 16, 2016
371580f
Force the permissions of the file to be public-read
Dec 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Force the permissions of the file to be public-read
  • Loading branch information
Fernando Blat committed Dec 16, 2016
commit 371580f10447621ff92bcc18665a64d5dd12830a
2 changes: 1 addition & 1 deletion lib/file_uploader/s3.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def call
object = resource.bucket(bucket_name).object(file_name)

File.open(file.tempfile, "rb") do |file_body|
object.put(body: file_body)
object.put(body: file_body, acl: 'public-read')
end

object.public_url
Expand Down