Keep context after User sign in #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works ok 💪 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #124.
What does this PR do?
This one updates the
after_sign_in_pathbehavior at User (GobiertoCore) level to take a referrer URL into account. To do so, theHTTP_REFERERis passed through the sign in form to keep a context to which we can redirect on success.How should this be manually tested?
Just check that the context is kept after a sign in action. In example, a sign in request from http:https://madrid.gobierto.dev/presupuestos/ejecucion/2016 should redirect back to the same URL.