Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Confirmation request and Password reset actions into the new session workflow #164

Merged
merged 3 commits into from
Dec 15, 2016

Conversation

danguita
Copy link
Contributor

@danguita danguita commented Dec 15, 2016

Comes up from #126.

What does this PR do?

First of all, this was not specified in the prototype but, after checking the entire workflow I missed some actions that would need to be implemented in order to keep a good experience.

This one implements the Confirmation email request as part of the new session workflow. This means that any User should be able to request a new confirmation email in the new session screen, as follows:

screen shot 2016-12-15 at 07 32 11

Clicking in "¿Instrucciones de confirmación?" ⬇️

screen shot 2016-12-15 at 07 32 17

Also, we're integrating the User password change behavior into the new front-end, and any alternative URLs have been dropped from the system actions:

screen shot 2016-12-15 at 07 59 45

In addition, any new screens are being localised into the three languages available now, so once again I'd need some help from my beloved Catalan translator @ferblape 🙏

How should this be manually tested?

Just get into the login screen at http:https://madrid.gobierto.dev/user/login, and check that:

  • The Confirmation request form can be reached from the new session block.
  • The Confirmation request works as expected, allowing the User to start a new confirmation process through an informative email.

In addition, let's check that the Password reset feature still works as expected and the Password edit form has the right styling:

  • http:https://madrid.gobierto.dev/user/passwords/edit?reset_password_token=<reset_password_token> looks good.

Help wanted ✋

@furilo Does that work for you?

@ferblape
Copy link
Member

LGTM!

@danguita
Copy link
Contributor Author

Thanks for those translations! 🙌 Waiting for the build to pass.

@danguita danguita merged commit 35b38fc into master Dec 15, 2016
@danguita danguita deleted the 126-user-sign-up-additional-workflow branch December 15, 2016 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants