Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New user Registration, Confirmation and session management workflow #160

Merged
merged 8 commits into from
Dec 14, 2016

Conversation

danguita
Copy link
Contributor

@danguita danguita commented Dec 14, 2016

Connects to #126.

What does this PR do?

This PR implements the latest specs regarding User registration and session management. In brief, it adds a new Registration and Confirmation workflow, which can be accessed right from the login screen. This updated UI is also providing a way for requesting a password change.

It is also localising and translating any related template by keeping conventions established in the GobiertoAdmin module.

What is missing?

Once again, I'd need some help with CA translations. I'm keeping them mirrored from ES versions to leave a placeholder to work with 馃檹

How should this be manually tested?

Just get into the new login screen at http:https://madrid.gobierto.dev/user/login, and check that:

  • Any User can recover her password.
  • Any Visitor can register in the new workflow: 1. Ask for email, 2. Ask for the remaining data.
  • Any User can start a session with valid credentials.
  • Every interaction is localised and translated into the current locale (please note the CA translations are not done yet).
  • The UI looks and behaves like the prototype.

Here're a couple of shots on those:

screen shot 2016-12-14 at 14 25 42

screen shot 2016-12-14 at 14 27 36

@ferblape
Copy link
Member

I have made a few changes:

1 - include missing Catalan translations, so now the feature is complete
2 - remove duplicated login routes
3 - fix the name of the gender attribute, because when there were validation errors, it wasn't very clear which attribute it was
4 - sorted and updated the years of the year of birth selector

@ferblape
Copy link
Member

BTW, great job!

@ferblape ferblape merged commit ecbe762 into master Dec 14, 2016
@ferblape ferblape deleted the 126-user-sign-up-workflow branch December 14, 2016 15:38
@@ -52,6 +52,6 @@ def get_user_genders
end

def get_user_years_of_birth
(18.years.ago.year..Date.current.year)
(100.years.ago.year..10.years.ago.year).to_a.reverse
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do need more sleep 馃槥

@danguita
Copy link
Contributor Author

Thanks for taking care, go ahead! 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants