Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Magnific Popup to v1.1.0 #158

Merged
merged 1 commit into from
Dec 14, 2016
Merged

Conversation

ferblape
Copy link
Member

Connects to #149

What does this PR do?

This PR updates the library to version 1.1.0

How should this be manually tested?

You should check magnific popup works now, for example, by creating or editing a budget line consultation item.

@danguita
Copy link
Contributor

Checking this one.

@danguita
Copy link
Contributor

It works just fine in Safari 10.0.2 (12602.3.12.0.1) and Chrome 55.0.2883.95 (64-bit). I'd move this one forward to master in order to let @furilo check it with his reported version of Safari.

screen shot 2016-12-14 at 16 19 44

So, LGTM 👍

@ferblape ferblape merged commit 779ba77 into master Dec 14, 2016
@ferblape ferblape deleted the 149-update-magnific-popup branch December 14, 2016 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants