Cover empty parameters edge case in Invitable behavior #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danguita
force-pushed
the
unplanned-enhance-invitable-behavior
branch
from
28a1c95
to
cc61556
Compare
|
New CI build in progress 🚀 |
|
Thanks for taking care. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unplanned.
What does this PR do?
Similar to #144 and #147, this PR is enhancing the User Invitable behavior by covering an edge case in which the User can pass a empty
invitation_tokenparameter.It is only being applied to
GobiertoAdmin::Adminentities.How should this be manually tested?
Just check that an Invitation acceptance URL with empty or missing
invitation_tokenparameter doesn't match any Users: