Complete Admin UI localization #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.03% (diff: 83.33%)@@ master #152 diff @@
==========================================
Files 114 115 +1
Lines 2454 2463 +9
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2184 2193 +9
Misses 270 270
Partials 0 0
|
|
Checking this one |
|
This looks OK to me. I麓ll take care of creating issues for the missing things. I can't talk now about the missing keys, I'll ping you! |
|
Thanks for taking care! No rush, this is not blocking us 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #99.
What does this PR do?
This PR runs through the entire Admin localizing every single action, adding missing translations, cleaning up and refactoring small pieces of code when needed.
What is missing?
Let's please talk about that.
How should this be manually tested?
Just get into the Admin namespace and check that every single section is translated into Spanish (which is the default locale for now), even when everything's also available in English as the master language for development:
http:https://gobierto.dev/admin/
Final notes
That's definitely a big one, thanks for checking 馃檹