Refactor Admin authentication related code #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Namespace Authentication concerns under the `Authentication` module. - Increase test coverage. - Put some TODO marks there for coming features.
|
The CI build is broken until we consider merging #14, so I'm ignoring the build status for now. It is passing locally. |
|
Merging this one by myself to move the feature forward /cc @ferblape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #10 and comes from #13.
What does this PR do?
Authenticationmodule.Admin::BaseControllerin terms of naming and method visibility.How should this be manually tested?
You should be asked for login credentials when trying to reach the admin namespace at http:https://gobierto.dev/admin/