Plans admin #1474
Plans admin #1474
Conversation
| @plan = find_plan | ||
|
|
||
| @plan_form = PlanForm.new( | ||
| plan_params.merge(id: params[:id], site_id: current_site.id) |
There was a problem hiding this comment.
no need to add the id to the plan_params
There was a problem hiding this comment.
But if I don't add it, when I update a plan, it generates a new one
| </h2> | ||
| <p> | ||
| <%= t(".description") %> | ||
| <%= @plan.introduction %> | ||
| </p> | ||
| <p> | ||
| <%= t(".latest_update_html", date: l(@plan.updated_at.to_date, format: :long)) %> |
There was a problem hiding this comment.
Instead of the plan.updated_at, use the activity gobierto_plans.plan_type_updated. That activity should be generated when the plans are updated in the API script. Check how is done for budgets.
config/routes.rb
Outdated
| namespace :gobierto_plans, as: :plans, path: :plans do | ||
| get "/" => "welcome#index" | ||
|
|
||
| resources :plans, only: [:show, :new, :create, :edit, :update, :destroy], path: "" do |
There was a problem hiding this comment.
I think those are all the actions 💃 You can remove the only.
config/routes.rb
Outdated
| get :data | ||
| put :recover | ||
| end | ||
| resources :plan_types, only: [:new, :create, :edit, :update, :destroy], path: :plan_types do |
| @@ -370,6 +370,100 @@ ToDo | |||
|
|
|||
| Los datos del módulo de Observatorio se cargan y se visualizan automáticamente. | |||
|
|
|||
| ### Planes | |||
Codecov Report
@@ Coverage Diff @@
## master #1474 +/- ##
==========================================
+ Coverage 78.47% 78.52% +0.04%
==========================================
Files 518 533 +15
Lines 13485 13849 +364
==========================================
+ Hits 10583 10875 +292
- Misses 2902 2974 +72
Continue to review full report at Codecov.
|
|
I uploaded the latest changes for the front of Plans, now you see GobiertoPlans through plan types and filtering by year you see the plan you want, so the year is a required field.
I made a refactor of the indicators, as the update date was missing and an importer has been added to the indicators, so there was a PR in populate-data-indicators.
|
|
The other PR has been merged, can you review the conflicts @apradillap? |
|
In Plans / new the title is: "New plan type" instead of "New plan". We are creating plans, not plan types in this page.
|
Closes #1457
✌️ What does this PR do?
New admin section: Plans
You can modify details in plans and plan types.
If you need more help, I 've added documentation:
https://github.com/PopulateTools/gobierto/blob/staging/docs/manual_admin.md
🔍 How should this be manually tested?
Create/update/archive a plan
Create/update/archive a plan type
👀 Screenshots
After this PR