Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pages and news #1473

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Refactor pages and news #1473

merged 1 commit into from
Feb 23, 2018

Conversation

ferblape
Copy link
Member

✌️ What does this PR do?

This PR implements partially #932

  • It simplifies the URLs of pages and news to be:
    • /paginas/collection-slug
    • /pagina/page-slug
  • It uses a template system depending on the collection container:
    • for site containers, pages use gobierto_cms/pages/templates/
    • for participation, pages use gobierto_participation/pages/templates/
    • for participation processes, pages use gobierto_participation/processes/pages/templates/

A lot of methods, templates and actions have been removed too.

🔍 How should this be manually tested?

Checking this issue will be hard. Here there are a few suggested steps:

  • check a collection of pages with a Site as container
  • check a collection of pages with Participation as container
  • check a collection of pages with a participation process as container
  • check a collection of news with a Site as container
  • check a collection of news with Participation as container
  • check a collection of news with a participation process as container
  • check a site where a section is configured as the home page
  • check the information page of a process
  • check the news page of participation
  • check the news page of a process

👀 Screenshots

Doesn't apply, it changes at URL level

@ferblape ferblape merged commit 1c9d73f into master Feb 23, 2018
@ferblape ferblape deleted the 932-unify-pages-news-urls branch February 23, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant