Consultation's budget amounts formatting #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #119.
What does this PR do?
This PR normalizes the budget amounts format across different sections on the UI, taking care of both server and client sides.
In the server side we're using a helper method to wrap the number formatting, while in client side we're propagating the same format options through a numeric format library which is included as a
GobiertoBudgetConsultations
specific vendor.How should this be manually tested?
Let's check that any budget amount in the Consultation response process match the following assertions:
Final notes
There would be slight differences between the server and client-side number formatting, although I would not care about them since there's an enhancement that will drop any repeated logic at #133.