Update resource management workflow in Admin namespace #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danguita
force-pushed
the
121-admin-management-workflow
branch
from
875f706
to
38f1256
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #121.
What does this PR do?
This PR slightly updates all Admin, User and Site management workflows by redirecting back to the edit action when performing an update request.
It also increases the test coverage by adding controller tests and refactoring the existing ones.
How should this be manually tested?
This could be tested by submitting an update of any of these resources and checking that the request gets redirected to the resource's edit URL, and shows the proper flash message.
i.e.:
http:https://gobierto.dev/admin/admins/<admin_id>/edit.http:https://gobierto.dev/admin/users/<user_id>/edit.http:https://gobierto.dev/admin/sites/<site_id>/edit.