Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PopulateData lib usage explicit to deal with autoloading issues #141

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

danguita
Copy link
Contributor

Connects to #140.

What does this PR do?

This is is likely a class autoloading problem in staging/production. Even when everything under /app is autoloaded in development and eager loaded in staging/production, I'd keep this library out of the app context so we're making the PopulateData::Gobierto class usage explicit. It is now needed to require "populate_data" when making use of that library.

How should this be manually tested?

Ensure that the PopulateData::Gobierto is properly loaded from GobiertoAdmin::GobiertoBudgetConsultations::BudgetLineCollectionBuilder in an eager loaded environment config such as staging or production.

It is only used in the Consultation Item management action so let's check this form still works:

http:https://gobierto.dev/admin/budgets/consultations/<consultation_id>/items/<consultation_item_id>/edit.

@ferblape
Copy link
Member

Let´s try it in staging. Thank you!

@ferblape ferblape merged commit 08fd972 into master Dec 12, 2016
@ferblape ferblape deleted the 140-budget-line-collection-builder-fix branch December 12, 2016 08:28
@danguita
Copy link
Contributor Author

Thanks man! 🙌

@ferblape
Copy link
Member

It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants