Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show feedback before trying to respond to closed Consultations #138

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

danguita
Copy link
Contributor

@danguita danguita commented Dec 9, 2016

Connects to #123.

What does this PR do?

This one shows feedback before trying to respond to closed Consultations.

Note that this is only adding feedback in the UI since we were already protecting this action in this ConsultationResponsesController's callback.

How should this be manually tested?

These are the three possible scenarios when reaching a Consultation screen at http:https://madrid.gobierto.dev/presupuestos/consultas/<consultation_id>:

  1. The Consultation is just open normally:

screen shot 2016-12-09 at 6 00 09 pm

  1. The Consultation is closed for some reason:

screen shot 2016-12-09 at 6 00 16 pm

  1. The Consultation is not yet open:

screen shot 2016-12-09 at 5 59 58 pm

@ferblape
Copy link
Member

ferblape commented Dec 9, 2016

👍

@ferblape ferblape merged commit b49b4ae into master Dec 9, 2016
@ferblape ferblape deleted the 123-feedback-on-closed-consultations branch December 9, 2016 17:50
@depfu depfu bot mentioned this pull request Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants