Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement modal-based front-end in Consultation items management UI #129

Merged
merged 3 commits into from
Dec 9, 2016

Conversation

danguita
Copy link
Contributor

@danguita danguita commented Dec 8, 2016

Connects to #92.

What does this PR do?

This PR comes as part of the batch of UI enhancements that need to be performed regarding the Consultation items management screen.

It adds support for managing Consultation items in modal windows taking advantage of asynchronous requests and the already present magnificPopup library. Both creation and edition views can be accessed in modal windows while the old fashioned views are still there as an alternative management workflow.

There's room for improvement here but I'd say it's good to keep iterating quickly and see how things are going.

How should this be manually tested?

Just check that any Consultation item can be added or edited in modal windows as in the screenshot below at http:https://gobierto.dev/admin/budgets/consultations/<consultation_item>/items:

screen shot 2016-12-08 at 10 38 49 am

In addition, check that the old fashioned synchronous views are still there (although not looking exactly the same as before to ensure compatibility) in any of the following URLs:

  • http:https://gobierto.dev/admin/budgets/consultations/<consultation_id>/items/new
  • http:https://gobierto.dev/admin/budgets/consultations/<consultation_id>/items/<consultation_item_id>/edit

Extra 🎱

Now that we've a pretty stable back-end, I've slightly refactored both GobiertoBudgetConsultation's ConsultationForm and ConsultationItemForm classes for consistency and ease of use.

@ferblape ferblape merged commit 9354e8d into master Dec 9, 2016
@ferblape ferblape deleted the 92-consultation-items-management-ui-modals branch December 9, 2016 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants