Section pages search #1038
Merged
Section pages search #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1038 +/- ##
=========================================
- Coverage 78.03% 77.8% -0.24%
=========================================
Files 421 421
Lines 10869 10888 +19
=========================================
- Hits 8482 8471 -11
- Misses 2387 2417 +30
Continue to review full report at Codecov.
|
ferblape
requested changes
Oct 24, 2017
| } else { | ||
| $('<div class="result"><p>No hay resultados</p></div>').appendTo($resultsContainer); | ||
| $('<div class="result"><p>'+I18n.t("layouts.search.no_results")+'</p></div>').appendTo($resultsContainer); | ||
| } | ||
|
|
||
| $('<div class="result"><small>'+I18n.t("layouts.search.powered_by")+'</small></div>').appendTo($resultsContainer); |
There was a problem hiding this comment.
It's a small detail, but that message is not very useful in the admin UI. Could we add a flag to remove the powered by if we are in the admin?
| if(window.searchClient.indexes.length == 1) { | ||
| var result = '<div class="activity_item">' + | ||
| '<h2>' + '<a class="tipsit" href=' + ["/admin/cms/pages/", d['objectID'], "/edit?collection_id=", d['collection_id']].join('') + | ||
| ' original-title="Arrastra y suelta en la parte izquierda para colocar esta página en el menú">' + |
| <script type="text/javascript"> | ||
| window.searchClient = { | ||
| client: algoliasearch('<%= Rails.application.secrets.algolia_application_id %>', '<%= Rails.application.secrets.algolia_search_api_key %>'), | ||
| indexes: ["gobierto_populate_<%= Rails.env %>_GobiertoCms::Page"], |
There was a problem hiding this comment.
Use this method to get the index name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #1014
What does this PR do?
To look for in the sections within the pages. Front autocomplete has been reused.
How should this be manually tested?
Go to /admin/cms/sections, create a section and it looks for in the pages
Reindex
Add collection to the indexing of the pages, so reindex it.
bundle exec rake algoliasearch:reindex