-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive Relativistic Boris Push #2708
Conversation
Add static stub files
…ines.rst Co-authored-by: Nick Murphy <[email protected]>
Co-authored-by: Nick Murphy <[email protected]>
…diography' into src-reformat-particle-tracker-radiography
Define `explicit_boris_relativistic` as an accepted integrator
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for submitting a pull request (PR) to PlasmaPy! ✨ The future of the project depends on contributors like you, so we deeply appreciate it! 🌱 Our contributor guide has information on:
Important PlasmaPy recently switched to an The bottom of this page shows several checks that are run for every PR. Don't worry if something broke! We break stuff all the time. 😺 Click on "Details" to learn why a check didn't pass. Please also feel free to ask for help. We do that all the time as well. 🌸 You can find us in our chat room or weekly community meeting & office hours. Here are some tips:
If this PR is marked as ready for review, someone should stop by to provide a code review and offer suggestions soon. ✅ If you don't get a review within a few days, please feel free to send us a reminder. Please also use SI units within PlasmaPy, except when there is strong justification otherwise or in some examples. We thank you once again! |
figured it out! There was some dependence on the initial velocity. I've set the initial velocity to zero for now until we can figure out a better alternative (setting it directly to some fraction of the final drift velocity wasn't working...) This just means that we have to discard the first 20 points or so to allow the particle to reach the expected drift velocity. edit: disregard, this is false. I was looking at plots of the relative errors |
Awesome! Kind of concerning it doesn't work with an initial velocity thought... any idea why that is? Want to make sure that's not an issue with the analytic solution or the pusher or something. |
Though it looks like it would be as simple as picking up a phase difference (plus the amplitude difference picked up by gamma)? |
Ah, got it, ok that's expected then! In that case I'd say this test looks good enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Few minor comments before we merge
src/plasmapy/diagnostics/charged_particle_radiography/synthetic_radiography.py
Outdated
Show resolved
Hide resolved
Implement adaptive termination condition given drift parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for polishing off this neglected old PR!!
Reimplements the relativistic Boris push integrator defined in #979 using the new
ParticleTracker
frameworkMust be merged after #2704