-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update labeler GitHub workflows #2690
Conversation
.github/labeler.yml
Outdated
plasmapy.analysis: | ||
- changed-files: | ||
- any-glob-to-any-file: 'plasmapy/analysis/**/*' | ||
- any-glob-to-any-file: '**/analysis/**/*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 This change makes it so that changes to any file in src/plasmapy/analysis
or tests/analysis
makes it so that this label gets applied.
.github/labeler.yml
Outdated
@@ -36,77 +36,126 @@ dependencies: | |||
|
|||
docs: | |||
- changed-files: | |||
- any-glob-to-any-file: ['.readthedocs.yml', 'changelog/*doc*.rst', 'docs/**/*', 'README.md'] | |||
- any-glob-to-any-file: ['.readthedocs.yml', 'changelog/*doc*.rst', 'docs/**/*'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 The **
here represents any number of directories, including zero.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2690 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 104 104
Lines 9435 9435
Branches 2159 2159
=======================================
Hits 8985 8985
Misses 273 273
Partials 177 177 ☔ View full report in Codecov by Sentry. |
Merging this now to be able to test if it works. (One of these years, I'm going to learn how to test GitHub Actions locally...) |
This repository makes use of the labeler GitHub Action, which labels pull request based on what files are being changed. This action saves us a lot of time because we don't need to label issues manually, while resulting in much more consistently applied labels. The switch to an
src
layout in #2598 broke some of the pull request labeler specifications. This PR fixes them, and makes some new additions.I updated the changelog guide for better consistency with labels, and also to update the towncrier build command which was broken.
I also updated the labels to be removed after a pull request is merged.