Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labeler GitHub workflows #2690

Merged
merged 11 commits into from
May 15, 2024
Merged

Conversation

namurphy
Copy link
Member

@namurphy namurphy commented May 14, 2024

This repository makes use of the labeler GitHub Action, which labels pull request based on what files are being changed. This action saves us a lot of time because we don't need to label issues manually, while resulting in much more consistently applied labels. The switch to an src layout in #2598 broke some of the pull request labeler specifications. This PR fixes them, and makes some new additions.

I updated the changelog guide for better consistency with labels, and also to update the towncrier build command which was broken.

I also updated the labels to be removed after a pull request is merged.

@github-actions github-actions bot added the GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) label May 14, 2024
plasmapy.analysis:
- changed-files:
- any-glob-to-any-file: 'plasmapy/analysis/**/*'
- any-glob-to-any-file: '**/analysis/**/*'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This change makes it so that changes to any file in src/plasmapy/analysis or tests/analysis makes it so that this label gets applied.

@@ -36,77 +36,126 @@ dependencies:

docs:
- changed-files:
- any-glob-to-any-file: ['.readthedocs.yml', 'changelog/*doc*.rst', 'docs/**/*', 'README.md']
- any-glob-to-any-file: ['.readthedocs.yml', 'changelog/*doc*.rst', 'docs/**/*']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 The ** here represents any number of directories, including zero.

@namurphy namurphy marked this pull request as ready for review May 14, 2024 23:05
@namurphy namurphy requested a review from a team as a code owner May 14, 2024 23:05
@namurphy namurphy requested review from ejohnson-96 and removed request for a team and ejohnson-96 May 14, 2024 23:05
@namurphy namurphy changed the title Update labeler GitHub Action Update labeler GitHub workflows May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (2af0dba) to head (6eeab9c).

❗ Current head 6eeab9c differs from pull request most recent head 2471b95. Consider uploading reports for the commit 2471b95 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2690   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files         104      104           
  Lines        9435     9435           
  Branches     2159     2159           
=======================================
  Hits         8985     8985           
  Misses        273      273           
  Partials      177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@namurphy
Copy link
Member Author

Merging this now to be able to test if it works. (One of these years, I'm going to learn how to test GitHub Actions locally...)

@namurphy namurphy merged commit 3cb0339 into PlasmaPy:main May 15, 2024
14 checks passed
@namurphy namurphy deleted the update-labeler branch May 15, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor guide GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant